]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
memory: emif: Use of_property_read_bool()
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 19:12:59 +0000 (13:12 -0600)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 2 Aug 2024 07:16:47 +0000 (09:16 +0200)
Use of_property_read_bool() to read boolean properties rather than
of_find_property(). This is part of a larger effort to remove callers
of of_find_property() and similar functions. of_find_property() leaks
the DT struct property and data pointers which is a problem for
dynamically allocated nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20240731191312.1710417-21-robh@kernel.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
drivers/memory/emif.c

index 8c5ad5c025fad1636b94f19dd5a365ccb18cc973..974ed641473e8789c1ca867a3f80945d4e6fd96a 100644 (file)
@@ -864,7 +864,7 @@ static void of_get_custom_configs(struct device_node *np_emif,
                                                be32_to_cpup(poll_intvl);
        }
 
-       if (of_find_property(np_emif, "extended-temp-part", &len))
+       if (of_property_read_bool(np_emif, "extended-temp-part"))
                cust_cfgs->mask |= EMIF_CUSTOM_CONFIG_EXTENDED_TEMP_PART;
 
        if (!is_custom_config_valid(cust_cfgs, emif->dev)) {
@@ -880,13 +880,9 @@ static void of_get_ddr_info(struct device_node *np_emif,
                struct ddr_device_info *dev_info)
 {
        u32 density = 0, io_width = 0;
-       int len;
 
-       if (of_find_property(np_emif, "cs1-used", &len))
-               dev_info->cs1_used = true;
-
-       if (of_find_property(np_emif, "cal-resistor-per-cs", &len))
-               dev_info->cal_resistors_per_cs = true;
+       dev_info->cs1_used = of_property_read_bool(np_emif, "cs1-used");
+       dev_info->cal_resistors_per_cs = of_property_read_bool(np_emif, "cal-resistor-per-cs");
 
        if (of_device_is_compatible(np_ddr, "jedec,lpddr2-s4"))
                dev_info->type = DDR_TYPE_LPDDR2_S4;
@@ -916,7 +912,6 @@ static struct emif_data *of_get_memory_device_details(
        struct ddr_device_info          *dev_info = NULL;
        struct emif_platform_data       *pd = NULL;
        struct device_node              *np_ddr;
-       int                             len;
 
        np_ddr = of_parse_phandle(np_emif, "device-handle", 0);
        if (!np_ddr)
@@ -944,7 +939,7 @@ static struct emif_data *of_get_memory_device_details(
 
        of_property_read_u32(np_emif, "phy-type", &pd->phy_type);
 
-       if (of_find_property(np_emif, "hw-caps-ll-interface", &len))
+       if (of_property_read_bool(np_emif, "hw-caps-ll-interface"))
                pd->hw_caps |= EMIF_HW_CAPS_LL_INTERFACE;
 
        of_get_ddr_info(np_emif, np_ddr, dev_info);