testsuite: add README

diff --git a/testsuite/README b/testsuite/README
new file mode 100644 (file)
index 0000000..38afe20
--- /dev/null
+++ b/testsuite/README
@@ -0,0 +1,54 @@
+testsuite
+
+OVERVIEW
+========
+
+Kmod's testsuite was designed to automate the process of running tests with
+different scenarios, configurations and architectures. The idea is that once we
+received a bug report, we reproduce it using the testsuite so we avoid
+recurring on the same bug in future.
+
+
+FEATURES
+========
+
+- Isolate each test by running them in separate processes;
+- Exec a binary, so we can test the tools and not only the lib API
+- Fake accesses to filesystem so we can provide a test rootfs with all the
+  configuration, indexes, etc that test needs to be executed.
+- Fake calls to init_module(), delete_module() and uname(), so we don't have to
+  run tests as root and figure out how to deal with different architectures.
+
+HOW TO ADD A TEST
+=================
+
+The simplest way to add a test is to copy and paste one already there. Most of
+the options you can have are covered by another tests. This is what you need to
+pay attention when writing a test:
+
+1 - Look at testsuite.h, struct test, to see all the options available.
+
+2 - Fill in the name and description. Convention is to have the name equal to
+    the function used to test and the struct name as s<function-name>
+
+3 - If you want testsuite to compare the stdout/stderr of your tests in order
+to check if it worked or not, fill in output.{stderr,stdout} the file with the
+expected output. Bare in mind the same file is used for all architectures, so
+don't print arch-dependent content if you are comparing the output.
+
+4 - Fill in the config vector. Setting any of these configuration will make
+testsuite to export LD_PRELOAD with the necessary override libs before
+executing the test. If you are not exec'ing an external binary, you need to
+pass "need_spawn = true" below, otherwise it will not work (LD_PRELOAD is only
+applied when exec'ing a binary). See each config description in testsuite.h
+
+5 - need_spawn: if testsuite will exec itself before running a test
+
+6 - expected_fail: if that test is expected to fail, i.e. the return code is
+expected not to be 0.
+
+7 - If you added files to the rootfs, be sure to compact it back to
+rootfs.tar.xz before sending patches.
+
+8 - Tests can be run individually, outside of 'make check'. strace and gdb work
+too, as long as you tell them to operate on child process.

diff --git a/testsuite/testsuite.h b/testsuite/testsuite.h
index 9081d84d3d4d5e9933f6a62bd4f944bf23934e9b..012e5103a87f695011e844e4d963903b6c49b406 100644 (file)
--- a/testsuite/testsuite.h
+++ b/testsuite/testsuite.h
@@ -25,10 +25,45 @@ struct test;
 typedef int (*testfunc)(const struct test *t);
 
 enum test_config {
+       /*
+        * Where's the roots dir for this test. It will LD_PRELOAD path.so in
+        * order to trap calls to functions using paths.
+        */
        TC_ROOTFS = 0,
+
+       /*
+        * What's the desired string to be returned by `uname -r`. It will
+        * trap calls to uname(3P) by LD_PRELOAD'ing uname.so and then filling
+        * in the information in u.release.
+        */
        TC_UNAME_R,
+
+       /*
+        * Fake calls to init_module(2), returning return-code and setting
+        * errno to err-code. Set this variable with the following format:
+        *
+        *        modname:return-code:err-code
+        *
+        * When this variable is used, all calls to init_module() are trapped
+        * and by default the return code is 0. In other words, they fake
+        * "success" for all modules, except the ones in the list above, for
+        * which the return codes are used.
+        */
        TC_INIT_MODULE_RETCODES,
+
+       /*
+        * Fake calls to delete_module(2), returning return-code and setting
+        * errno to err-code. Set this variable with the following format:
+        *
+        *        modname:return-code:err-code
+        *
+        * When this variable is used, all calls to init_module() are trapped
+        * and by default the return code is 0. In other words, they fake
+        * "success" for all modules, except the ones in the list above, for
+        * which the return codes are used.
+        */
        TC_DELETE_MODULE_RETCODES,
+
        _TC_LAST,
 };