]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: bcm: bcm63xx: Use scope based of_node_put() cleanups
authorPeng Fan <peng.fan@nxp.com>
Sat, 4 May 2024 13:20:14 +0000 (21:20 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 26 Jun 2024 09:59:00 +0000 (11:59 +0200)
Use scope based of_node_put() cleanup to simplify code.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/20240504-pinctrl-cleanup-v2-16-26c5f2dc1181@nxp.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/bcm/pinctrl-bcm63xx.c

index e1285fe2fbc07cd3d73d94cbe8d4805716946212..59d2ce8462d84d1c5ea5fb53fa361e577a0986e9 100644 (file)
@@ -67,7 +67,6 @@ int bcm63xx_pinctrl_probe(struct platform_device *pdev,
 {
        struct device *dev = &pdev->dev;
        struct bcm63xx_pinctrl *pc;
-       struct device_node *node;
        int err;
 
        pc = devm_kzalloc(dev, sizeof(*pc), GFP_KERNEL);
@@ -94,12 +93,11 @@ int bcm63xx_pinctrl_probe(struct platform_device *pdev,
        if (IS_ERR(pc->pctl_dev))
                return PTR_ERR(pc->pctl_dev);
 
-       for_each_child_of_node(dev->parent->of_node, node) {
+       for_each_child_of_node_scoped(dev->parent->of_node, node) {
                if (of_match_node(bcm63xx_gpio_of_match, node)) {
                        err = bcm63xx_gpio_probe(dev, node, soc, pc);
                        if (err) {
                                dev_err(dev, "could not add GPIO chip\n");
-                               of_node_put(node);
                                return err;
                        }
                }