]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
i386: Fix ICE with V64QImode broadcast permutation with -mavx512f -mno-avx512bw
authorJakub Jelinek <jakub@redhat.com>
Sat, 14 Aug 2021 09:44:46 +0000 (11:44 +0200)
committerJakub Jelinek <jakub@redhat.com>
Sat, 14 Aug 2021 09:44:46 +0000 (11:44 +0200)
The testcase shows another problem, for TARGET_AVX512BW we have a single insn
doing broadcast from the first element, but don't have one for broadcast
of 2nd+ element (so for d->perm[0] we must return false), but for
TARGET_AVX512F && !TARGET_AVX512BW we don't even have support for that other
broadcast.  V64QImode case was just added to the AVX2 cases which had
gcc_assert (!TARGET_AVX2 || d->perm[0]);
but for V64QImode we actually need
gcc_assert (!TARGET_AVX512BW || d->perm[0]);

2021-08-14  Jakub Jelinek  <jakub@redhat.com>

PR target/101896
* config/i386/i386-expand.c (expand_vec_perm_broadcast_1)
<case E_V64QImode>: For this mode assert
!TARGET_AVX512BW || d->perm[0] rather than !TARGET_AVX2 || d->perm[0].

* gcc.target/i386/avx512f-pr101896.c: New test.

gcc/config/i386/i386-expand.c
gcc/testsuite/gcc.target/i386/avx512f-pr101896.c [new file with mode: 0644]

index a652b25f5345afb4a98b673ddb83edc24418279c..4d7349cfc7c51685d8e8431c05e0f113197076bf 100644 (file)
@@ -20474,7 +20474,6 @@ expand_vec_perm_broadcast_1 (struct expand_vec_perm_d *d)
       emit_move_insn (d->target, gen_lowpart (d->vmode, dest));
       return true;
 
-    case E_V64QImode:
     case E_V32QImode:
     case E_V16HImode:
     case E_V8SImode:
@@ -20484,6 +20483,10 @@ expand_vec_perm_broadcast_1 (struct expand_vec_perm_d *d)
       gcc_assert (!TARGET_AVX2 || d->perm[0]);
       return false;
 
+    case E_V64QImode:
+      gcc_assert (!TARGET_AVX512BW || d->perm[0]);
+      return false;
+
     case E_V32HImode:
       gcc_assert (!TARGET_AVX512BW);
       return false;
diff --git a/gcc/testsuite/gcc.target/i386/avx512f-pr101896.c b/gcc/testsuite/gcc.target/i386/avx512f-pr101896.c
new file mode 100644 (file)
index 0000000..c1805cc
--- /dev/null
@@ -0,0 +1,5 @@
+/* PR target/101896 */
+/* { dg-do compile } */
+/* { dg-options "-O2 -mavx512f -mno-avx512bw" } */
+
+#include "../../gcc.dg/torture/vshuf-v64qi.c"