Fix logic error in rev.14321

 Using !=0 on both string compares means any login= value will permit
 40x responses through. Only PASS and PASSTHRU should be doing that.

 Detected by Coverity Scan. Issue 1364711

diff --git a/src/tunnel.cc b/src/tunnel.cc
index de62c732a0dd5af67d1b4a3683e0759f7782d91c..0a76aaa452e9516bbd8283a4e996d570345383e7 100644 (file)
--- a/src/tunnel.cc
+++ b/src/tunnel.cc
@@ -499,7 +499,7 @@ TunnelStateData::handleConnectResponse(const size_t chunkSize)
 
     // we need to relay the 401/407 responses when login=PASS(THRU)
     const char *pwd = server.conn->getPeer()->login;
-    const bool relay = pwd && (strcmp(pwd, "PASS") != 0 || strcmp(pwd, "PASSTHRU") != 0) &&
+    const bool relay = pwd && (strcmp(pwd, "PASS") == 0 || strcmp(pwd, "PASSTHRU") == 0) &&
                        (*status_ptr == Http::scProxyAuthenticationRequired ||
                         *status_ptr == Http::scUnauthorized);