Fix path of regress shared library in pg_upgrade test

During a pg_upgrade test using an old dump, all references to the old
regress shared library path (so, dylib or dll) are updated to point to
the library path used by the new build, to ensure a consistent
comparison between the old and new dumps.

The test previously relied on a hardcoded value of "src/test/regress/"
to build the new path value, which would point to an incorrect location
for the meson and vpath builds.  This is replaced by REGRESS_SHLIB, able
to point to the correct location of the regress shared library.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/a628d8ad-a08a-2eab-4ca9-641bc82d3193@gmail.com
Backpatch-through: 15

diff --git a/src/bin/pg_upgrade/t/002_pg_upgrade.pl b/src/bin/pg_upgrade/t/002_pg_upgrade.pl
index 700afd5d79e9286be42824d30bd4ca16aed1b8dc..ceca3ac5cf4d3a49410adf83a7cf446287cf289c 100644 (file)
--- a/src/bin/pg_upgrade/t/002_pg_upgrade.pl
+++ b/src/bin/pg_upgrade/t/002_pg_upgrade.pl
@@ -221,7 +221,7 @@ if (defined($ENV{oldinstall}))
 
        my $dump_data = slurp_file($dump1_file);
 
-       my $newregresssrc = "$srcdir/src/test/regress";
+       my $newregresssrc = dirname($ENV{REGRESS_SHLIB});
        foreach (@libpaths)
        {
                my $libpath = $_;