]> git.ipfire.org Git - thirdparty/git.git/commitdiff
cmake/vcxproj: stop special-casing `remote-ext`
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Tue, 17 Dec 2024 17:32:01 +0000 (17:32 +0000)
committerJunio C Hamano <gitster@pobox.com>
Tue, 17 Dec 2024 20:48:54 +0000 (12:48 -0800)
When the `vcxproj` target was introduced in `config.mak.uname` to allow
building Git with the Visual C toolchain, the `git remote-ext` command
was always executed in its dashed form. Therefore, it was impossible to
pass the test suite unless that command existed in its dashed form, and
we had to special-case this.

Later, when the `vcxproj` target got out of fashion because Visual
Studio gained native support for CMake builds, this special-casing was
copied without questioning it.

But as of 675df192c5f (transport-helper: do not run git-remote-ext etc.
in dashed form, 2020-08-26), the reason for this special-casing no
longer exists. So let's just drop it.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
config.mak.uname
contrib/buildsystems/CMakeLists.txt

index d5112168a4cbfda2db851c44974ecd7d3b3ec0cd..b12d4e168ae11905391be45a41420a973ee610a9 100644 (file)
@@ -819,10 +819,6 @@ vcxproj:
        sed -i 's|\(git\)-\([-a-z]*\)\.exe"|\1.exe" \2|g' \
                bin-wrappers/git-{receive-pack,upload-archive}
        git add -f $(test_bindir_programs)
-       # remote-ext is a builtin, but invoked as if it were external
-       sed 's|receive-pack|remote-ext|g' \
-               <bin-wrappers/git-receive-pack >bin-wrappers/git-remote-ext
-       git add -f bin-wrappers/git-remote-ext
 
        # Add templates
        $(MAKE) -C templates
index 36f18ab2dd13deea609811b550e844ed5a8eac9a..802445c1eb0e8b109d79083367553f3892ce5084 100644 (file)
@@ -1082,7 +1082,7 @@ endif()
 
 #wrapper scripts
 set(wrapper_scripts
-       git git-upload-pack git-receive-pack git-upload-archive git-shell git-remote-ext scalar)
+       git git-upload-pack git-receive-pack git-upload-archive git-shell scalar)
 
 set(wrapper_test_scripts
        test-fake-ssh test-tool)