]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: r8188eu: remove RT_TRACE calls from hal/usb_halinit.c
authorPhillip Potter <phil@philpotter.co.uk>
Tue, 3 Aug 2021 23:05:34 +0000 (00:05 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Aug 2021 11:00:17 +0000 (13:00 +0200)
Remove RT_TRACE macro calls from hal/usb_halinit.c, so that ultimately the
macro definition itself can eventually be removed.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210803230535.74254-8-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/usb_halinit.c

index 919bcbd9f3183e730e60051c9d22ebd622464345..2981c3075ae815dd0fe567c26953f584ae0eb80a 100644 (file)
@@ -712,10 +712,8 @@ static u32 rtl8188eu_hal_init(struct adapter *Adapter)
 
        HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_INIT_PW_ON);
        status = rtl8188eu_InitPowerOn(Adapter);
-       if (status == _FAIL) {
-               RT_TRACE(_module_hci_hal_init_c_, _drv_err_, ("Failed to init power on!\n"));
+       if (status == _FAIL)
                goto exit;
-       }
 
        /*  Save target channel */
        haldata->CurrentChannel = 6;/* default set to 6 */
@@ -757,7 +755,6 @@ static u32 rtl8188eu_hal_init(struct adapter *Adapter)
                        haldata->fw_ractrl = false;
                        return status;
                } else {
-                       RT_TRACE(_module_hci_hal_init_c_, _drv_info_, ("Initializeadapt8192CSdio(): Download Firmware Success!!\n"));
                        Adapter->bFWReady = true;
                        haldata->fw_ractrl = false;
                }
@@ -805,10 +802,8 @@ static u32 rtl8188eu_hal_init(struct adapter *Adapter)
 
        HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_INIT_LLTT);
        status =  InitLLTTable(Adapter, txpktbuf_bndy);
-       if (status == _FAIL) {
-               RT_TRACE(_module_hci_hal_init_c_, _drv_err_, ("Failed to init LLT table\n"));
+       if (status == _FAIL)
                goto exit;
-       }
 
        HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_MISC02);
        /*  Get Rx PHY status in order to report RSSI and others. */
@@ -968,8 +963,6 @@ static void CardDisableRTL8188EU(struct adapter *Adapter)
        u8 val8;
        struct hal_data_8188e   *haldata        = GET_HAL_DATA(Adapter);
 
-       RT_TRACE(_module_hci_hal_init_c_, _drv_info_, ("CardDisableRTL8188EU\n"));
-
        /* Stop Tx Report Timer. 0x4EC[Bit1]=b'0 */
        val8 = rtw_read8(Adapter, REG_TX_RPT_CTRL);
        rtw_write8(Adapter, REG_TX_RPT_CTRL, val8&(~BIT1));
@@ -1067,16 +1060,12 @@ static unsigned int rtl8188eu_inirp_init(struct adapter *Adapter)
 
        status = _SUCCESS;
 
-       RT_TRACE(_module_hci_hal_init_c_, _drv_info_,
-                ("===> usb_inirp_init\n"));
-
        precvpriv->ff_hwaddr = RECV_BULK_IN_ADDR;
 
        /* issue Rx irp to receive data */
        precvbuf = (struct recv_buf *)precvpriv->precv_buf;
        for (i = 0; i < NR_RECVBUFF; i++) {
                if (_read_port(pintfhdl, precvpriv->ff_hwaddr, 0, (unsigned char *)precvbuf) == false) {
-                       RT_TRACE(_module_hci_hal_init_c_, _drv_err_, ("usb_rx_init: usb_read_port error\n"));
                        status = _FAIL;
                        goto exit;
                }
@@ -1086,20 +1075,13 @@ static unsigned int rtl8188eu_inirp_init(struct adapter *Adapter)
        }
 
 exit:
-
-       RT_TRACE(_module_hci_hal_init_c_, _drv_info_, ("<=== usb_inirp_init\n"));
-
        return status;
 }
 
 static unsigned int rtl8188eu_inirp_deinit(struct adapter *Adapter)
 {
-       RT_TRACE(_module_hci_hal_init_c_, _drv_info_, ("\n ===> usb_rx_deinit\n"));
-
        rtw_read_port_cancel(Adapter);
 
-       RT_TRACE(_module_hci_hal_init_c_, _drv_info_, ("\n <=== usb_rx_deinit\n"));
-
        return _SUCCESS;
 }
 
@@ -1156,11 +1138,6 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool
                /* Read Permanent MAC address */
                memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN);
        }
-       RT_TRACE(_module_hci_hal_init_c_, _drv_notice_,
-                ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n",
-                eeprom->mac_addr[0], eeprom->mac_addr[1],
-                eeprom->mac_addr[2], eeprom->mac_addr[3],
-                eeprom->mac_addr[4], eeprom->mac_addr[5]));
 }
 
 static void Hal_CustomizeByCustomerID_8188EU(struct adapter *adapt)