terminal: always reset terminal when reading without echo

Break out of the loop to ensure restore_term() is called before
returning.

Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/compat/terminal.c b/compat/terminal.c
index 5b903e7c7e3e32c25e59efcc151217d00d243d65..fb8c70a625118e96dd93b791d83bbfedd71dad1f 100644 (file)
--- a/compat/terminal.c
+++ b/compat/terminal.c
@@ -385,7 +385,7 @@ int read_key_without_echo(struct strbuf *buf)
 
                        ch = getchar();
                        if (ch == EOF)
-                               return 0;
+                               break;
                        strbuf_addch(buf, ch);
                }
        }