]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli: Avoid an unnecessary "else"
authorVolker Lendecke <vl@samba.org>
Thu, 28 Nov 2024 08:47:20 +0000 (09:47 +0100)
committerMartin Schwenke <martins@samba.org>
Mon, 2 Dec 2024 04:53:33 +0000 (04:53 +0000)
We return in the error case anyway

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
libcli/security/sddl_conditional_ace.c

index 62323a300a0ce53963297266119ae246523a14cd..0d2d4d041dc868d1f4852fee71a4ccf4a24a8f51 100644 (file)
@@ -2053,9 +2053,8 @@ static bool parse_sid(struct ace_condition_sddl_compiler_context *comp)
            comp->sddl[comp->offset + 3] != '(') {
                comp_error(comp, "malformed SID() constructor");
                return false;
-       } else {
-               comp->offset += 4;
        }
+       comp->offset += 4;
 
        sidstr = comp->sddl + comp->offset;