conf: change virDomainDefAddImplicitControllers() to return void

It can't fail.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index e945a0740cff494d81e3d21b67532da856088317..f42b7075ad7f87af9a1cb8c3f7dec8d43b6a6808 100644 (file)
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -22346,7 +22346,7 @@ virDomainDefMaybeAddSmartcardController(virDomainDef *def)
  * in the XML. This is for compat with existing apps which will
  * not know/care about <controller> info in the XML
  */
-static int
+static void
 virDomainDefAddImplicitControllers(virDomainDef *def)
 {
     virDomainDefAddDiskControllersForType(def, VIR_DOMAIN_CONTROLLER_TYPE_SCSI,
@@ -22361,8 +22361,6 @@ virDomainDefAddImplicitControllers(virDomainDef *def)
     virDomainDefMaybeAddVirtioSerialController(def);
     virDomainDefMaybeAddSmartcardController(def);
     virDomainDefMaybeAddHostdevSCSIcontroller(def);
-
-    return 0;
 }
 
 static int
@@ -22389,8 +22387,7 @@ virDomainDefAddImplicitDevices(virDomainDef *def, virDomainXMLOption *xmlopt)
         if (virDomainDefAddConsoleCompat(def) < 0)
             return -1;
     }
-    if (virDomainDefAddImplicitControllers(def) < 0)
-        return -1;
+    virDomainDefAddImplicitControllers(def);
 
     if (virDomainDefAddImplicitVideo(def, xmlopt) < 0)
         return -1;