]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
printk: ringbuffer: Explain why the KUnit test ignores failed writes
authorPetr Mladek <pmladek@suse.com>
Wed, 2 Jul 2025 09:51:55 +0000 (11:51 +0200)
committerPetr Mladek <pmladek@suse.com>
Thu, 10 Jul 2025 15:11:57 +0000 (17:11 +0200)
The KUnit test ignores prb_reserve() failures on purpose. It tries
to push the ringbuffer beyond limits.

Note that it is a know problem that writes might fail in this situation.
printk() tries to prevent this problem by:

  + allocating big enough data buffer, see log_buf_add_cpu().

  + allocating enough descriptors by using small enough average
    record, see PRB_AVGBITS.

  + storing the record with disabled interrupts, see vprintk_store().

Also the amount of printk() messages is always somehow bound in
practice. And they are serialized when they are printed from
many CPUs on purpose, for example, when printing backtraces.

Reviewed-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Link: https://patch.msgid.link/20250702095157.110916-2-pmladek@suse.com
Signed-off-by: Petr Mladek <pmladek@suse.com>
kernel/printk/printk_ringbuffer_kunit_test.c

index 4081ae051d8e63fe195095118f2e8370ddd0737e..217dcc14670cd5d17ee412a11ccf784afd7343b9 100644 (file)
@@ -123,6 +123,19 @@ static int prbtest_writer(void *data)
                /* specify the text sizes for reservation */
                prb_rec_init_wr(&r, record_size);
 
+               /*
+                * Reservation can fail if:
+                *
+                *      - No free descriptor is available.
+                *      - The buffer is full, and the oldest record is reserved
+                *        but not yet committed.
+                *
+                * It actually happens in this test because all CPUs are trying
+                * to write an unbounded number of messages in a tight loop.
+                * These failures are intentionally ignored because this test
+                * focuses on races, ringbuffer consistency, and pushing system
+                * usability limits.
+                */
                if (prb_reserve(&e, tr->test_data->ringbuffer, &r)) {
                        r.info->text_len = record_size;