]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Fix uninitialized variable in libadaptation
authorAmos Jeffries <squid3@treenet.co.nz>
Wed, 8 Feb 2017 17:57:26 +0000 (06:57 +1300)
committerAmos Jeffries <squid3@treenet.co.nz>
Wed, 8 Feb 2017 17:57:26 +0000 (06:57 +1300)
The grokBool() parse method does not alter the bool parameter on invalid
inputs. This results in encrypt local variabel bein gused uninitialized.

src/adaptation/ServiceConfig.cc

index ad7f5409c33e038cdeac3f136243d84227b3a687..1d4697bc842fe984d89649cab6fa6f54b47c7d6b 100644 (file)
@@ -139,7 +139,7 @@ Adaptation::ServiceConfig::parse()
             grokked = grokOnOverload(onOverload, value);
             onOverloadSet = true;
         } else if (strcmp(name, "connection-encryption") == 0) {
-            bool encrypt;
+            bool encrypt = false;
             grokked = grokBool(encrypt, name, value);
             connectionEncryption.configure(encrypt);
         } else if (strncmp(name, "ssl", 3) == 0 || strncmp(name, "tls-", 4) == 0) {