]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: mwifiex: Fix dev_alloc_name() return value check
authorChen-Yu Tsai <wenst@chromium.org>
Tue, 10 Feb 2026 10:03:34 +0000 (18:03 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 23 Feb 2026 08:25:48 +0000 (09:25 +0100)
dev_alloc_name() returns the allocated ID on success, which could be
over 0.

Fix the return value check to check for negative error codes.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aYmsQfujoAe5qO02@stanley.mountain/
Fixes: 7bab5bdb81e3 ("wifi: mwifiex: Allocate dev name earlier for interface workqueue name")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Link: https://patch.msgid.link/20260210100337.1131279-1-wenst@chromium.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/marvell/mwifiex/cfg80211.c

index a66d18e380fc5e91871917979554aab0b2ae0791..bc0a946e8e6e96777e8fce3c7de5a20ee730a60d 100644 (file)
@@ -3148,7 +3148,7 @@ struct wireless_dev *mwifiex_add_virtual_intf(struct wiphy *wiphy,
        SET_NETDEV_DEV(dev, adapter->dev);
 
        ret = dev_alloc_name(dev, name);
-       if (ret)
+       if (ret < 0)
                goto err_alloc_name;
 
        priv->dfs_cac_workqueue = alloc_workqueue("MWIFIEX_DFS_CAC-%s",