]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
drm/vc4: drv: Add error handding for bind
authorHoegeun Kwon <hoegeun.kwon@samsung.com>
Tue, 27 Oct 2020 04:14:42 +0000 (13:14 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 10 Nov 2020 09:29:06 +0000 (10:29 +0100)
[ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ]

There is a problem that if vc4_drm bind fails, a memory leak occurs on
the drm_property_create side. Add error handding for drm_mode_config.

Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20201027041442.30352-2-hoegeun.kwon@samsung.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/vc4/vc4_drv.c

index 1c96edcb302be825cb3aeb438ab9a59c63fb6052..028dc2819a368123fd41bd92000cb967be515268 100644 (file)
@@ -283,6 +283,7 @@ unbind_all:
        component_unbind_all(dev, drm);
 gem_destroy:
        vc4_gem_destroy(drm);
+       drm_mode_config_cleanup(drm);
        vc4_bo_cache_destroy(drm);
 dev_unref:
        drm_dev_unref(drm);