]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/msm: fix %s null argument error
authorSherry Yang <sherry.yang@oracle.com>
Tue, 27 Aug 2024 16:53:37 +0000 (09:53 -0700)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sun, 1 Sep 2024 23:53:44 +0000 (02:53 +0300)
The following build error was triggered because of NULL string argument:

BUILDSTDERR: drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c: In function 'mdp5_smp_dump':
BUILDSTDERR: drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c:352:51: error: '%s' directive argument is null [-Werror=format-overflow=]
BUILDSTDERR:   352 |                         drm_printf(p, "%s:%d\t%d\t%s\n",
BUILDSTDERR:       |                                                   ^~
BUILDSTDERR: drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c:352:51: error: '%s' directive argument is null [-Werror=format-overflow=]

This happens from the commit a61ddb4393ad ("drm: enable (most) W=1
warnings by default across the subsystem"). Using "(null)" instead
to fix it.

Fixes: bc5289eed481 ("drm/msm/mdp5: add debugfs to show smp block status")
Signed-off-by: Sherry Yang <sherry.yang@oracle.com>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/611071/
Link: https://lore.kernel.org/r/20240827165337.1075904-1-sherry.yang@oracle.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c

index 3a7f7edda96b27108a307c28ebf438285efdba7a..500b7dc895d05554e729f8608ce76ec021bcee1f 100644 (file)
@@ -351,7 +351,7 @@ void mdp5_smp_dump(struct mdp5_smp *smp, struct drm_printer *p,
 
                        drm_printf(p, "%s:%d\t%d\t%s\n",
                                pipe2name(pipe), j, inuse,
-                               plane ? plane->name : NULL);
+                               plane ? plane->name : "(null)");
 
                        total += inuse;
                }