hwmon: (asus-ec-sensors) check sensor index in read_string()

Prevent a potential invalid memory access when the requested sensor
is not found.

find_ec_sensor_index() may return a negative value (e.g. -ENOENT),
but its result was used without checking, which could lead to
undefined behavior when passed to get_sensor_info().

Add a proper check to return -EINVAL if sensor_index is negative.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: d0ddfd241e57 ("hwmon: (asus-ec-sensors) add driver for ASUS EC")
Signed-off-by: Alexei Safin <a.safin@rosa.ru>
Link: https://lore.kernel.org/r/20250424202654.5902-1-a.safin@rosa.ru
[groeck: Return error code returned from find_ec_sensor_index]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index d1f91376231873434807c1629a9b14a181a6ea58..964673c6759750b5e73f9328abc8a83a50d64bbf 100644 (file)
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -955,6 +955,10 @@ static int asus_ec_hwmon_read_string(struct device *dev,
 {
        struct ec_sensors_data *state = dev_get_drvdata(dev);
        int sensor_index = find_ec_sensor_index(state, type, channel);
+
+       if (sensor_index < 0)
+               return sensor_index;
+
        *str = get_sensor_info(state, sensor_index)->label;
 
        return 0;