BUG/MINOR: sock: Unclosed fd in case of connection allocation failure

If allocating a connection object failed right after a successful accept
on a listener, the new file descriptor was not properly closed.

This fixes GitHub issue #905.
It can be backported to 2.3.

diff --git a/src/sock.c b/src/sock.c
index 20ebdd0e4e595b99947f26530d26b3b8cec89b7f..596be43d6c008a009d3dc7a1a0f6008001823234 100644 (file)
--- a/src/sock.c
+++ b/src/sock.c
@@ -161,6 +161,9 @@ struct connection *sock_accept_conn(struct listener *l, int *status)
 
  fail_conn:
        sockaddr_free(&addr);
+       /* The accept call already succeeded by the time we try to allocate the connection,
+        * we need to close it in case of failure. */
+       close(cfd);
  fail_addr:
        ret = CO_AC_PAUSE;
        goto done;