]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: samsung: exynos4-is: Use %pe format specifier
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 13 Oct 2025 14:15:09 +0000 (14:15 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:16 +0000 (11:31 +0200)
The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./platform/samsung/exynos4-is/media-dev.c:1337:16-23: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/samsung/exynos4-is/media-dev.c

index c781853586fd21996105c050e587bf8079cfc095..d6f7601de597e3d3517ef9195d728deb578e74f1 100644 (file)
@@ -1333,8 +1333,8 @@ static int fimc_md_register_clk_provider(struct fimc_md *fmd)
 
                cp->clks[i] = clk_register(NULL, &camclk->hw);
                if (IS_ERR(cp->clks[i])) {
-                       dev_err(dev, "failed to register clock: %s (%ld)\n",
-                                       init.name, PTR_ERR(cp->clks[i]));
+                       dev_err(dev, "failed to register clock: %s (%pe)\n",
+                               init.name, cp->clks[i]);
                        ret = PTR_ERR(cp->clks[i]);
                        goto err;
                }