]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
btrfs: send: simplify return logic from send_unlink()
authorFilipe Manana <fdmanana@suse.com>
Thu, 20 Feb 2025 10:58:38 +0000 (10:58 +0000)
committerDavid Sterba <dsterba@suse.com>
Tue, 18 Mar 2025 19:35:46 +0000 (20:35 +0100)
There is no need to have an 'out' label and jump into it since there are
no resource cleanups to perform (release locks, free memory, etc), so
make this simpler by removing the label and goto and instead return
directly.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/send.c

index bda229c7084b30d74f1a7cc7511d32649affe9ef..cbc9ca9db062ea950eb9bb810c2470cd8c527981 100644 (file)
@@ -856,14 +856,13 @@ static int send_unlink(struct send_ctx *sctx, struct fs_path *path)
 
        ret = begin_cmd(sctx, BTRFS_SEND_C_UNLINK);
        if (ret < 0)
-               goto out;
+               return ret;
 
        TLV_PUT_PATH(sctx, BTRFS_SEND_A_PATH, path);
 
        ret = send_cmd(sctx);
 
 tlv_put_failure:
-out:
        return ret;
 }