libsmb: Use nybble_to_hex_upper() in smbc_urlencode()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>

diff --git a/source3/libsmb/libsmb_path.c b/source3/libsmb/libsmb_path.c
index 615de1c398bc482942849846af96ac0f76f98210..12bfd21065cd0333ae62c2ecb7f77d9d169749f3 100644 (file)
--- a/source3/libsmb/libsmb_path.c
+++ b/source3/libsmb/libsmb_path.c
@@ -131,8 +131,6 @@ smbc_urlencode(char *dest,
                char *src,
                int max_dest_len)
 {
-        char hex[] = "0123456789ABCDEF";
-
         for (; *src != '\0' && max_dest_len >= 3; src++) {
 
                 if ((*src < '0' &&
@@ -145,8 +143,8 @@ smbc_urlencode(char *dest,
                      *src != '_') ||
                     (*src > 'z')) {
                         *dest++ = '%';
-                        *dest++ = hex[(*src >> 4) & 0x0f];
-                        *dest++ = hex[*src & 0x0f];
+                        *dest++ = nybble_to_hex_upper(*src >> 4);
+                        *dest++ = nybble_to_hex_upper(*src);
                         max_dest_len -= 3;
                 } else {
                         *dest++ = *src;