drm/amd/display: Fix mismatch type comparison

The mismatch type comparison/assignment may cause data loss. Since the
values are always non-negative, it is safe to use unsigned variables to
resolve the mismatch.

Signed-off-by: Navid Assadian <navid.assadian@amd.com>
Reviewed-by: Joshua Aberback <joshua.aberback@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.c b/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.c
index 72a79288ab7955787a72c9b5712c9e2538ec4507..3d85732cc0f57490464ef7acb870ce8756531d62 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.c
+++ b/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.c
@@ -944,8 +944,8 @@ static bool spl_get_optimal_number_of_taps(
          bool *enable_isharp)
 {
        int num_part_y, num_part_c;
-       int max_taps_y, max_taps_c;
-       int min_taps_y, min_taps_c;
+       unsigned int max_taps_y, max_taps_c;
+       unsigned int min_taps_y, min_taps_c;
        enum lb_memory_config lb_config;
        bool skip_easf = false;
        bool is_subsampled = spl_is_subsampled_format(spl_in->basic_in.format);

diff --git a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl_types.h b/drivers/gpu/drm/amd/display/dc/sspl/dc_spl_types.h
index 0130673ceee6793485f7bc61114b9d1b9c9da739..1c3949b24611f647984270c0667ff6ef2729c9da 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl_types.h
+++ b/drivers/gpu/drm/amd/display/dc/sspl/dc_spl_types.h
@@ -493,7 +493,7 @@ struct spl_sharpness_range {
 };
 struct adaptive_sharpness {
        bool enable;
-       int sharpness_level;
+       unsigned int sharpness_level;
        struct spl_sharpness_range sharpness_range;
 };
 enum linear_light_scaling      {       // convert it in translation logic