]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/sched: Return an error code only as a constant in drm_sched_init()
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 26 Dec 2023 15:37:37 +0000 (16:37 +0100)
committerLuben Tuikov <ltuikov89@gmail.com>
Mon, 8 Jan 2024 03:37:25 +0000 (22:37 -0500)
Return an error code without storing it in an intermediate variable.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://patchwork.freedesktop.org/patch/msgid/85f8004e-f0c9-42d9-8c59-30f1b4e0b89e@web.de
Reviewed-by: Luben Tuikov <ltuikov89@gmail.com>
Signed-off-by: Luben Tuikov <ltuikov89@gmail.com>
drivers/gpu/drm/scheduler/sched_main.c

index b99d4e9ff1094426113221b3c0486334590e72fa..1abbcdf38430e8e3ab226ec094a0a7ea1ecb8c16 100644 (file)
@@ -1249,7 +1249,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched,
                   long timeout, struct workqueue_struct *timeout_wq,
                   atomic_t *score, const char *name, struct device *dev)
 {
-       int i, ret;
+       int i;
 
        sched->ops = ops;
        sched->credit_limit = credit_limit;
@@ -1285,7 +1285,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched,
 
                sched->own_submit_wq = true;
        }
-       ret = -ENOMEM;
+
        sched->sched_rq = kmalloc_array(num_rqs, sizeof(*sched->sched_rq),
                                        GFP_KERNEL | __GFP_ZERO);
        if (!sched->sched_rq)
@@ -1321,7 +1321,7 @@ Out_check_own:
        if (sched->own_submit_wq)
                destroy_workqueue(sched->submit_wq);
        drm_err(sched, "%s: Failed to setup GPU scheduler--out of memory\n", __func__);
-       return ret;
+       return -ENOMEM;
 }
 EXPORT_SYMBOL(drm_sched_init);