]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
usb: dwc3: Don't call clk_bulk_disable_unprepare() twice
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 29 Sep 2025 18:28:50 +0000 (20:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Oct 2025 07:37:10 +0000 (09:37 +0200)
devm_clk_bulk_get_all_enabled() is used in the probe, so
clk_bulk_disable_unprepare() should not be called explicitly in the remove
function.

Fixes: e0b6dc00c701 ("usb: dwc3: add generic driver to support flattened")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-generic-plat.c

index d96b20570002dc619ea813f4d6a8013636a0f346..f8ad79c08c4e5c39b119c4762fd5b79d1b1374ad 100644 (file)
@@ -85,11 +85,8 @@ static int dwc3_generic_probe(struct platform_device *pdev)
 static void dwc3_generic_remove(struct platform_device *pdev)
 {
        struct dwc3 *dwc = platform_get_drvdata(pdev);
-       struct dwc3_generic *dwc3g = to_dwc3_generic(dwc);
 
        dwc3_core_remove(dwc);
-
-       clk_bulk_disable_unprepare(dwc3g->num_clocks, dwc3g->clks);
 }
 
 static int dwc3_generic_suspend(struct device *dev)