]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
[gdb/testsuite] Add missing returns in gdb.threads/infcall-from-bp-cond-simple.c
authorTom de Vries <tdevries@suse.de>
Thu, 20 Mar 2025 11:37:04 +0000 (12:37 +0100)
committerTom de Vries <tdevries@suse.de>
Thu, 20 Mar 2025 11:37:04 +0000 (12:37 +0100)
While investigating PR32785 I noticed a missing return statement in
worker_func, and compiling with -Wreturn-type showed another in
function_that_segfaults:
...
$ gcc gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.c -Wreturn-type
infcall-from-bp-cond-simple.c: In function ‘function_that_segfaults’:
infcall-from-bp-cond-simple.c:46:1: warning: \
  control reaches end of non-void function [-Wreturn-type]
   46 | }
      | ^
infcall-from-bp-cond-simple.c: In function ‘worker_func’:
infcall-from-bp-cond-simple.c:58:1: warning: \
  control reaches end of non-void function [-Wreturn-type]
   58 | }
      | ^
...

Fix these by adding the missing returns.

gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.c

index 2e23f1229c599f9c4f3faabb346996130ee9103a..d0707cd2e9fc5a17e34682059dce1e998397ba79 100644 (file)
@@ -43,6 +43,7 @@ function_that_segfaults ()
 {
   int *p = 0;
   *p = 1;      /* Segfault happens here.   */
+  return 0;
 }
 
 int
@@ -55,6 +56,7 @@ void *
 worker_func (void *arg)
 {
   int a = 42;  /* Breakpoint here.  */
+  return NULL;
 }
 
 void