]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: allegro: print warning if channel creation timeout occurs
authorMatthias Fend <matthias.fend@emfend.at>
Mon, 1 Sep 2025 15:13:36 +0000 (17:13 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Mon, 20 Oct 2025 07:23:17 +0000 (09:23 +0200)
This message can be helpful for troubleshooting and there is already a
corresponding message in case of a channel destroy timeout.
Add a similar message for channel creation.

Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/allegro-dvt/allegro-core.c

index f347d56ac10891c5dcf7196c54952a43b19cc1da..be56ef682845a3702292461a091a08d26a1782cd 100644 (file)
@@ -2602,8 +2602,14 @@ static int allegro_create_channel(struct allegro_channel *channel)
        allegro_mcu_send_create_channel(dev, channel);
        time_left = wait_for_completion_timeout(&channel->completion,
                                                msecs_to_jiffies(5000));
-       if (time_left == 0)
+       if (time_left == 0) {
+               v4l2_warn(&dev->v4l2_dev,
+                         "user %d: timeout while creating channel\n",
+                         channel->user_id);
+
                channel->error = -ETIMEDOUT;
+       }
+
        if (channel->error)
                goto err;