]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
io_uring: delete misleading comment in io_fill_cqe_aux()
authorPavel Begunkov <asml.silence@gmail.com>
Mon, 28 Apr 2025 12:52:32 +0000 (13:52 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 28 Apr 2025 17:51:31 +0000 (11:51 -0600)
io_fill_cqe_aux() doesn't overflow completions, however it might fail
them and lets the caller handle it. Remove the comment, which doesn't
make any sense.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/021aa8c1d8f20ef2b66da6aeabb6b511938fd2c5.1745843119.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/io_uring.c

index 2e4d8e76316a865bc56f9e021a50d8f766845982..703251f6f4d810139de4b4ed3f65e0a494fe2aac 100644 (file)
@@ -814,11 +814,6 @@ static bool io_fill_cqe_aux(struct io_ring_ctx *ctx, u64 user_data, s32 res,
 
        ctx->cq_extra++;
 
-       /*
-        * If we can't get a cq entry, userspace overflowed the
-        * submission (by quite a lot). Increment the overflow count in
-        * the ring.
-        */
        if (likely(io_get_cqe(ctx, &cqe))) {
                WRITE_ONCE(cqe->user_data, user_data);
                WRITE_ONCE(cqe->res, res);