]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
Fix a memory leak on WPA authenticator error path
authorJouni Malinen <j@w1.fi>
Thu, 8 Jan 2015 00:22:03 +0000 (02:22 +0200)
committerJouni Malinen <j@w1.fi>
Thu, 8 Jan 2015 00:34:08 +0000 (02:34 +0200)
wpa_auth->group needs to be freed if PMK cache setup fails.

Signed-off-by: Jouni Malinen <j@w1.fi>
src/ap/wpa_auth.c

index da2073c0a22af7dd37be2f88bd25e5f2bc0fdd22..059b8848da135ed6e02af118ffc81b17f3f3cc2d 100644 (file)
@@ -415,6 +415,7 @@ struct wpa_authenticator * wpa_init(const u8 *addr,
                                                wpa_auth);
        if (wpa_auth->pmksa == NULL) {
                wpa_printf(MSG_ERROR, "PMKSA cache initialization failed.");
+               os_free(wpa_auth->group);
                os_free(wpa_auth->wpa_ie);
                os_free(wpa_auth);
                return NULL;
@@ -424,6 +425,7 @@ struct wpa_authenticator * wpa_init(const u8 *addr,
        wpa_auth->ft_pmk_cache = wpa_ft_pmk_cache_init();
        if (wpa_auth->ft_pmk_cache == NULL) {
                wpa_printf(MSG_ERROR, "FT PMK cache initialization failed.");
+               os_free(wpa_auth->group);
                os_free(wpa_auth->wpa_ie);
                pmksa_cache_auth_deinit(wpa_auth->pmksa);
                os_free(wpa_auth);