regcache: flat: Remove unneeded check and error message for -ENOMEM

There is a convention in the kernel to avoid error messages
in the cases of -ENOMEM errors. Besides that, the idea behind
using struct_size() and other macros from overflow.h is
to saturate the size that the following allocation call will
definitely fail, hence the check and the error messaging added
in regcache_flat_init() are redundant. Remove them.

Acked-by: Sander Vanheule <sander@svanheule.net>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20251031080540.3970776-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/base/regmap/regcache-flat.c b/drivers/base/regmap/regcache-flat.c
index 3b9235bb8313a66bfba7db884f4722cfeabe1a4a..bacb7137092face879c572cb0e0dd0bfe69b69f1 100644 (file)
--- a/drivers/base/regmap/regcache-flat.c
+++ b/drivers/base/regmap/regcache-flat.c
@@ -30,7 +30,6 @@ struct regcache_flat_data {
 static int regcache_flat_init(struct regmap *map)
 {
        int i;
-       size_t cache_data_size;
        unsigned int cache_size;
        struct regcache_flat_data *cache;
 
@@ -38,14 +37,7 @@ static int regcache_flat_init(struct regmap *map)
                return -EINVAL;
 
        cache_size = regcache_flat_get_index(map, map->max_register) + 1;
-       cache_data_size = struct_size(cache, data, cache_size);
-
-       if (cache_data_size == SIZE_MAX) {
-               dev_err(map->dev, "cannot allocate regmap cache");
-               return -ENOMEM;
-       }
-
-       cache = kzalloc(cache_data_size, map->alloc_flags);
+       cache = kzalloc(struct_size(cache, data, cache_size), map->alloc_flags);
        if (!cache)
                return -ENOMEM;