]> git.ipfire.org Git - people/ms/linux.git/commitdiff
tracing: Test the 'Do not trace this pid' case in create event
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Sat, 27 Nov 2021 21:45:26 +0000 (16:45 -0500)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Sat, 27 Nov 2021 21:50:43 +0000 (16:50 -0500)
When creating a new event (via a module, kprobe, eprobe, etc), the
descriptors that are created must add flags for pid filtering if an
instance has pid filtering enabled, as the flags are used at the time the
event is executed to know if pid filtering should be done or not.

The "Only trace this pid" case was added, but a cut and paste error made
that case checked twice, instead of checking the "Trace all but this pid"
case.

Link: https://lore.kernel.org/all/202111280401.qC0z99JB-lkp@intel.com/
Fixes: 6cb206508b62 ("tracing: Check pid filtering when creating events")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_events.c

index f8965fd50d3be41b6fa02b1508bb3e5d99badf91..92be9cb1d7d4bc313507e3a1f516b4517701bc8e 100644 (file)
@@ -2693,7 +2693,7 @@ trace_create_new_event(struct trace_event_call *call,
                                             lockdep_is_held(&event_mutex));
 
        if (!trace_pid_list_first(pid_list, &first) ||
-           !trace_pid_list_first(pid_list, &first))
+           !trace_pid_list_first(no_pid_list, &first))
                file->flags |= EVENT_FILE_FL_PID_FILTER;
 
        file->event_call = call;