drm/msm/a6xx: Print GMU core firmware version at boot

Log the version for informational purposes, such as for keeping track
of possible GMU fw-related failures in crash / CI logs.

Intentionally not implemented on the if (gmu->legacy) codepath, as
these registers seem not to be used on there.

Downstream additionally warns if the firmware version is too old for
a given GPU, but we already pair the binary to a given GPU, so let's
not go there at the moment.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/629934/
Signed-off-by: Rob Clark <robdclark@chromium.org>

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index cd659ed99783821e6081446a6323bca6006ad0ce..cde6ac2a27b2a57b5d75100395c455e1cb5bdec0 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -729,6 +729,7 @@ static int a6xx_gmu_fw_load(struct a6xx_gmu *gmu)
        const struct firmware *fw_image = adreno_gpu->fw[ADRENO_FW_GMU];
        const struct block_header *blk;
        u32 reg_offset;
+       u32 ver;
 
        u32 itcm_base = 0x00000000;
        u32 dtcm_base = 0x00040000;
@@ -775,6 +776,12 @@ static int a6xx_gmu_fw_load(struct a6xx_gmu *gmu)
                }
        }
 
+       ver = gmu_read(gmu, REG_A6XX_GMU_CORE_FW_VERSION);
+       DRM_INFO("Loaded GMU firmware v%u.%u.%u\n",
+                FIELD_GET(A6XX_GMU_CORE_FW_VERSION_MAJOR__MASK, ver),
+                FIELD_GET(A6XX_GMU_CORE_FW_VERSION_MINOR__MASK, ver),
+                FIELD_GET(A6XX_GMU_CORE_FW_VERSION_STEP__MASK, ver));
+
        return 0;
 }