lib-storage: Fix truncating header values at NUL when adding to cache

For example FETCH BODY.PEEK[HEADER.FIELDS (Subject)] could have returned
the NUL on the first fetch when the mail wasn't in dovecot.index.cache,
but the second FETCH would have returned it truncated at the NUL.

diff --git a/src/lib-storage/index/index-mail-headers.c b/src/lib-storage/index/index-mail-headers.c
index b57ac099bde1704e2028f777579a41bd9f6be02d..a9653646b689cdadc960efc4de99c120c0e0b3cb 100644 (file)
--- a/src/lib-storage/index/index-mail-headers.c
+++ b/src/lib-storage/index/index-mail-headers.c
@@ -346,7 +346,7 @@ void index_mail_parse_header(struct message_part *part,
                   cache as nonexistent. */
                match[field_idx] |= HEADER_MATCH_FLAG_FOUND;
        }
-       str_append_n(mail->header_data, hdr->value, hdr->value_len);
+       str_append_data(mail->header_data, hdr->value, hdr->value_len);
        if (!hdr->no_newline)
                str_append(mail->header_data, "\n");
        if (!hdr->continues) {