]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: mn88443x: Use %pe format specifier
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 13 Oct 2025 14:14:43 +0000 (14:14 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:15 +0000 (11:31 +0200)
The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR()

This patch fixes this cocci report:
./dvb-frontends/mn88443x.c:698:3-10: WARNING: Consider using %pe to print PTR_ERR()
./dvb-frontends/mn88443x.c:713:3-10: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/dvb-frontends/mn88443x.c

index 7a58f53ab9996031e319711a21b1a8f1c13abed4..818c4e67364c7c6ec2bfc17f21e2cac360f6bfb3 100644 (file)
@@ -694,8 +694,7 @@ static int mn88443x_probe(struct i2c_client *client)
 
        chip->mclk = devm_clk_get(dev, "mclk");
        if (IS_ERR(chip->mclk) && !conf) {
-               dev_err(dev, "Failed to request mclk: %ld\n",
-                       PTR_ERR(chip->mclk));
+               dev_err(dev, "Failed to request mclk: %pe\n", chip->mclk);
                return PTR_ERR(chip->mclk);
        }
 
@@ -709,8 +708,8 @@ static int mn88443x_probe(struct i2c_client *client)
        chip->reset_gpio = devm_gpiod_get_optional(dev, "reset",
                                                   GPIOD_OUT_HIGH);
        if (IS_ERR(chip->reset_gpio)) {
-               dev_err(dev, "Failed to request reset_gpio: %ld\n",
-                       PTR_ERR(chip->reset_gpio));
+               dev_err(dev, "Failed to request reset_gpio: %pe\n",
+                       chip->reset_gpio);
                return PTR_ERR(chip->reset_gpio);
        }