]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
powerpc/ps3: replace open-coded sysfs_emit function
authorPaulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
Sat, 19 Oct 2024 02:13:49 +0000 (15:13 +1300)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 5 Nov 2024 09:45:32 +0000 (20:45 +1100)
sysfs_emit() helper function should be used when formatting the value
to be returned to user space.

This patch replaces open-coded sysfs_emit() in sysfs .show() callbacks

Link: https://github.com/KSPP/linux/issues/105
Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://patch.msgid.link/ZxMV3YvSulJFZ8rk@mail.google.com
arch/powerpc/platforms/ps3/system-bus.c

index b9a7d9bae687e84920cb1dbde72404aa079394e1..afbaabf182d013e7f4d535dacc68db313c202e9e 100644 (file)
@@ -453,10 +453,9 @@ static ssize_t modalias_show(struct device *_dev, struct device_attribute *a,
        char *buf)
 {
        struct ps3_system_bus_device *dev = ps3_dev_to_system_bus_dev(_dev);
-       int len = snprintf(buf, PAGE_SIZE, "ps3:%d:%d\n", dev->match_id,
-                          dev->match_sub_id);
 
-       return (len >= PAGE_SIZE) ? (PAGE_SIZE - 1) : len;
+       return sysfs_emit(buf, "ps3:%d:%d\n", dev->match_id,
+                         dev->match_sub_id);
 }
 static DEVICE_ATTR_RO(modalias);