Infra queries should not use refresh mode.

When I introduced serve state in #11776, I reintroduced the mistake previously fixed in #11376.
Fixes #12078

diff --git a/pdns/syncres.cc b/pdns/syncres.cc
index c1287fc9b4f164937af118aa34992b181d931696..52da63debb4a36bafe293e2744fd2a08226739e0 100644 (file)
--- a/pdns/syncres.cc
+++ b/pdns/syncres.cc
@@ -2086,9 +2086,6 @@ vector<ComboAddress> SyncRes::getAddrs(const DNSName &qname, unsigned int depth,
   if (d_serveStale) {
     flags |= MemRecursorCache::ServeStale;
   }
-  if (d_refresh) {
-    flags |= MemRecursorCache::Refresh;
-  }
   try {
     // First look for both A and AAAA in the cache
     res_t cset;
@@ -2236,9 +2233,6 @@ void SyncRes::getBestNSFromCache(const DNSName &qname, const QType qtype, vector
   if (d_serveStale) {
     flags |= MemRecursorCache::ServeStale;
   }
-  if (d_refresh) {
-    flags |= MemRecursorCache::Refresh;
-  }
   do {
     if (cutOffDomain && (subdomain == *cutOffDomain || !subdomain.isPartOf(*cutOffDomain))) {
       break;