]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/damon/tests/core-kunit: handle alloc failres in damon_test_new_filter()
authorSeongJae Park <sj@kernel.org>
Sat, 1 Nov 2025 18:20:07 +0000 (11:20 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Nov 2025 01:28:33 +0000 (17:28 -0800)
damon_test_new_filter() is assuming all dynamic memory allocation in it
will succeed.  Those are indeed likely in the real use cases since those
allocations are too small to fail, but theoretically those could fail.  In
the case, inappropriate memory access can happen.  Fix it by appropriately
cleanup pre-allocated memory and skip the execution of the remaining tests
in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-14-sj@kernel.org
Fixes: 2a158e956b98 ("mm/damon/core-test: add a test for damos_new_filter()")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [6.6+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/tests/core-kunit.h

index b9bd69a57e62eb51b98468a3a8d6962fa19cbd0e..03c7ac31db5cff9de010978c2feeb8031b04c847 100644 (file)
@@ -505,6 +505,8 @@ static void damos_test_new_filter(struct kunit *test)
        struct damos_filter *filter;
 
        filter = damos_new_filter(DAMOS_FILTER_TYPE_ANON, true, false);
+       if (!filter)
+               kunit_skip(test, "filter alloc fail");
        KUNIT_EXPECT_EQ(test, filter->type, DAMOS_FILTER_TYPE_ANON);
        KUNIT_EXPECT_EQ(test, filter->matching, true);
        KUNIT_EXPECT_PTR_EQ(test, filter->list.prev, &filter->list);