auth: auth_worker_call() - Return void instead of the connection

The return value is no longer necessary, and it most likely would just be
used wrong.

diff --git a/src/auth/auth-worker-connection.c b/src/auth/auth-worker-connection.c
index 248b0b6c6bd52e32e06db3a3550a42fd9083255c..290ebefaa4ccca3ec2e59857ab164e2f2268e552 100644 (file)
--- a/src/auth/auth-worker-connection.c
+++ b/src/auth/auth-worker-connection.c
@@ -478,9 +478,8 @@ static const struct connection_vfuncs auth_worker_connection_funcs =
        .input_args = worker_input_args,
 };
 
-struct auth_worker_connection *
-auth_worker_call(pool_t pool, const char *username, const char *data,
-                auth_worker_callback_t *callback, void *context)
+void auth_worker_call(pool_t pool, const char *username, const char *data,
+                     auth_worker_callback_t *callback, void *context)
 {
        struct auth_worker_connection *worker;
        struct auth_worker_request *request;
@@ -510,7 +509,6 @@ auth_worker_call(pool_t pool, const char *username, const char *data,
                /* reached the limit, queue the request */
                aqueue_append(worker_request_queue, &request);
        }
-       return worker;
 }
 
 void auth_worker_connection_resume_input(struct auth_worker_connection *worker)

diff --git a/src/auth/auth-worker-connection.h b/src/auth/auth-worker-connection.h
index a4dd76417fa97078db8ca3cd9bdc3b3751168111..bdce677dbfe0fdd46c60d7e005220e74390651ad 100644 (file)
--- a/src/auth/auth-worker-connection.h
+++ b/src/auth/auth-worker-connection.h
@@ -8,9 +8,8 @@ struct auth_worker_connection;
 typedef bool auth_worker_callback_t(struct auth_worker_connection *conn,
                                    const char *const *args, void *context);
 
-struct auth_worker_connection * ATTR_NOWARN_UNUSED_RESULT
-auth_worker_call(pool_t pool, const char *username, const char *data,
-                auth_worker_callback_t *callback, void *context);
+void auth_worker_call(pool_t pool, const char *username, const char *data,
+                     auth_worker_callback_t *callback, void *context);
 void auth_worker_connection_resume_input(struct auth_worker_connection *conn);
 
 void auth_worker_connection_init(void);