]> git.ipfire.org Git - thirdparty/git.git/commitdiff
builtin/replace: make hash size independent
authorbrian m. carlson <sandals@crustytoothpaste.net>
Sun, 18 Aug 2019 20:04:02 +0000 (20:04 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 19 Aug 2019 22:04:57 +0000 (15:04 -0700)
Instead of using GIT_SHA1_HEXSZ and hard-coded constants, switch to
using the_hash_algo.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/replace.c

index 644b21ca8d57a75fa83ecbf0e58dd07a685cd9e4..4b00f1d84ee4e7ee6838ba012b27ad0a236f7c7d 100644 (file)
@@ -272,7 +272,7 @@ static int import_object(struct object_id *oid, enum object_type type,
                        return error(_("unable to spawn mktree"));
                }
 
-               if (strbuf_read(&result, cmd.out, 41) < 0) {
+               if (strbuf_read(&result, cmd.out, the_hash_algo->hexsz + 1) < 0) {
                        error_errno(_("unable to read from mktree"));
                        close(fd);
                        close(cmd.out);
@@ -358,14 +358,15 @@ static int replace_parents(struct strbuf *buf, int argc, const char **argv)
        struct strbuf new_parents = STRBUF_INIT;
        const char *parent_start, *parent_end;
        int i;
+       const unsigned hexsz = the_hash_algo->hexsz;
 
        /* find existing parents */
        parent_start = buf->buf;
-       parent_start += GIT_SHA1_HEXSZ + 6; /* "tree " + "hex sha1" + "\n" */
+       parent_start += hexsz + 6; /* "tree " + "hex sha1" + "\n" */
        parent_end = parent_start;
 
        while (starts_with(parent_end, "parent "))
-               parent_end += 48; /* "parent " + "hex sha1" + "\n" */
+               parent_end += hexsz + 8; /* "parent " + "hex sha1" + "\n" */
 
        /* prepare new parents */
        for (i = 0; i < argc; i++) {