]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
ARM: dts: lager: Configure pull-up for SOFT_SW GPIO keys
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 30 Apr 2021 13:10:52 +0000 (15:10 +0200)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 31 May 2021 08:45:40 +0000 (10:45 +0200)
The GPIO pins connected to the 4 Software Switches (SW2) do not have
external pull-up resistors, but rely on internal pull-ups being enabled.
Fortunately this is satisfied by the initial state of these pins.

Make this explicit by enabling bias-pull-up, to remove the dependency on
initial state and/or boot loader configuration.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/9fae3c0c2c0000f6b43c9ce87fe64a594b30a7da.1619785905.git.geert+renesas@glider.be
arch/arm/boot/dts/r8a7790-lager.dts

index 2dad0742d2ba159bec8f38181d8c66d2235441ba..fa6d986b5d4632cf16a3a4c7f40b23c7cd3245f8 100644 (file)
@@ -81,6 +81,9 @@
        keyboard {
                compatible = "gpio-keys";
 
+               pinctrl-0 = <&keyboard_pins>;
+               pinctrl-names = "default";
+
                one {
                        linux,code = <KEY_1>;
                        label = "SW2-1";
                groups = "audio_clk_a";
                function = "audio_clk";
        };
+
+       keyboard_pins: keyboard {
+               pins = "GP_1_14", "GP_1_24", "GP_1_26", "GP_1_28";
+               bias-pull-up;
+       };
 };
 
 &ether {