]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
dnsdist: No need to multiply 1.0 in cache-miss ratio dynblocks 13492/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Fri, 8 Dec 2023 16:19:12 +0000 (17:19 +0100)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Mon, 11 Dec 2023 08:45:43 +0000 (09:45 +0100)
As suggested by Charles-Henri, thanks!

pdns/dnsdistdist/dnsdist-dynblocks.cc

index 5e7d970c5063ee08098a2726df26c4e33505eae1..b7baca2be7154118fd49b07e33b9becaccc03623 100644 (file)
@@ -949,7 +949,7 @@ bool DynBlockRulesGroup::DynBlockCacheMissRatioRule::checkGlobalCacheHitRatio()
   if (globalMisses == 0 || globalHits == 0) {
     return false;
   }
-  double globalCacheHitRatio = (static_cast<double>(globalHits) * static_cast<double>(1.0)) / static_cast<double>(globalHits + globalMisses);
+  double globalCacheHitRatio = static_cast<double>(globalHits) / static_cast<double>(globalHits + globalMisses);
   return globalCacheHitRatio >= d_minimumGlobalCacheHitRatio;
 }