smb: client: get rid of kstrdup() when parsing iocharset mount option

Steal string reference from @param->string rather than duplicating it.

Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
Reviewed-by: David Howells <dhowells@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c
index 8b7ad5bf3302b662686965bff1f15494986830ba..3f34bb07997b9bfe8c1671e1248778f8a534bb32 100644 (file)
--- a/fs/smb/client/fs_context.c
+++ b/fs/smb/client/fs_context.c
@@ -1532,11 +1532,7 @@ static int smb3_fs_context_parse_param(struct fs_context *fc,
 
                if (strncasecmp(param->string, "default", 7) != 0) {
                        kfree(ctx->iocharset);
-                       ctx->iocharset = kstrdup(param->string, GFP_KERNEL);
-                       if (ctx->iocharset == NULL) {
-                               cifs_errorf(fc, "OOM when copying iocharset string\n");
-                               goto cifs_parse_mount_err;
-                       }
+                       ctx->iocharset = no_free_ptr(param->string);
                }
                /* if iocharset not set then load_nls_default
                 * is used by caller