]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: dac: ti-dac7311: Add check for spi_setup
authorChen Ni <nichen@iscas.ac.cn>
Fri, 5 Jul 2024 08:42:50 +0000 (16:42 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 29 Jul 2024 19:31:13 +0000 (20:31 +0100)
Add check for the return value of spi_setup() and return the error
if it fails in order to catch the error.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Link: https://patch.msgid.link/20240705084250.3006527-1-nichen@iscas.ac.cn
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ti-dac7311.c

index 7f89d2a52f49c412ff85d4842f6f1438d58c0590..6f4aa4794a0cabe07ea5a73522826891f23e04c1 100644 (file)
@@ -249,7 +249,9 @@ static int ti_dac_probe(struct spi_device *spi)
 
        spi->mode = SPI_MODE_1;
        spi->bits_per_word = 16;
-       spi_setup(spi);
+       ret = spi_setup(spi);
+       if (ret < 0)
+               return dev_err_probe(dev, ret, "spi_setup failed\n");
 
        indio_dev->info = &ti_dac_info;
        indio_dev->name = spi_get_device_id(spi)->name;