]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/xe: Add page queue multiplier
authorMatthew Brost <matthew.brost@intel.com>
Tue, 8 Apr 2025 15:59:15 +0000 (08:59 -0700)
committerMatthew Brost <matthew.brost@intel.com>
Thu, 10 Apr 2025 02:15:11 +0000 (19:15 -0700)
For an unknown reason the math to determine the PF queue size does is
not correct - compute UMD applications are overflowing the PF queue
which is fatal. A multippier of 8 fixes the problem.

Fixes: 3338e4f90c14 ("drm/xe: Use topology to determine page fault queue size")
Cc: stable@vger.kernel.org
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Jagmeet Randhawa <jagmeet.randhawa@intel.com>
Link: https://lore.kernel.org/r/20250408155915.78770-1-matthew.brost@intel.com
drivers/gpu/drm/xe/xe_gt_pagefault.c

index 9fa11e837dd184b379bb68e9bda7d84bff78c0c4..10622ca471a283d655b9877d02c39e8a79fbd6b3 100644 (file)
@@ -435,9 +435,16 @@ static int xe_alloc_pf_queue(struct xe_gt *gt, struct pf_queue *pf_queue)
        num_eus = bitmap_weight(gt->fuse_topo.eu_mask_per_dss,
                                XE_MAX_EU_FUSE_BITS) * num_dss;
 
-       /* user can issue separate page faults per EU and per CS */
+       /*
+        * user can issue separate page faults per EU and per CS
+        *
+        * XXX: Multiplier required as compute UMD are getting PF queue errors
+        * without it. Follow on why this multiplier is required.
+        */
+#define PF_MULTIPLIER  8
        pf_queue->num_dw =
-               (num_eus + XE_NUM_HW_ENGINES) * PF_MSG_LEN_DW;
+               (num_eus + XE_NUM_HW_ENGINES) * PF_MSG_LEN_DW * PF_MULTIPLIER;
+#undef PF_MULTIPLIER
 
        pf_queue->gt = gt;
        pf_queue->data = devm_kcalloc(xe->drm.dev, pf_queue->num_dw,