[clang-tidy:Ccast] Avoid a C cast and modernize.

Code inspired by how it's done in test-dnsrecords_cc.cc.

diff --git a/pdns/dnsparser.cc b/pdns/dnsparser.cc
index 19edfa42faec4942362ec47efd1d525d867ced34..9a2ee1a5994960be7bded2b3020c1e467a197c9d 100644 (file)
--- a/pdns/dnsparser.cc
+++ b/pdns/dnsparser.cc
@@ -114,7 +114,7 @@ shared_ptr<DNSRecordContent> DNSRecordContent::deserialize(const DNSName& qname,
     (void) pos;
   }
 
-  MOADNSParser mdp(false, (char*)&*packet.begin(), (unsigned int)packet.size());
+  MOADNSParser mdp(false, reinterpret_cast<const char *>(packet.data()), packet.size());
   shared_ptr<DNSRecordContent> ret= mdp.d_answers.begin()->first.d_content;
   return ret;
 }