]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
qcow2: Fix error handling in grow_refcount_table
authorKevin Wolf <kwolf@redhat.com>
Wed, 20 Jan 2010 14:03:03 +0000 (15:03 +0100)
committerAnthony Liguori <aliguori@us.ibm.com>
Wed, 27 Jan 2010 13:52:12 +0000 (07:52 -0600)
Return the appropriate error code instead of -EIO.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
(cherry picked from commit f2b7c8b37045e0e030ef027cfb6d574558fb732a)

block/qcow2-refcount.c

index 54b19f86dd9f5d4e81c84aecdc7d9b5f96c6868d..9fb28383cf06f9d26baa251c1e9212c72cf0cb57 100644 (file)
@@ -168,9 +168,12 @@ static int grow_refcount_table(BlockDriverState *bs, int min_size)
 
     cpu_to_be64w((uint64_t*)data, table_offset);
     cpu_to_be32w((uint32_t*)(data + 8), refcount_table_clusters);
-    if (bdrv_pwrite(s->hd, offsetof(QCowHeader, refcount_table_offset),
-                    data, sizeof(data)) != sizeof(data))
+    ret = bdrv_pwrite(s->hd, offsetof(QCowHeader, refcount_table_offset),
+                    data, sizeof(data));
+    if (ret != sizeof(data)) {
         goto fail;
+    }
+
     qemu_free(s->refcount_table);
     old_table_offset = s->refcount_table_offset;
     old_table_size = s->refcount_table_size;
@@ -183,7 +186,7 @@ static int grow_refcount_table(BlockDriverState *bs, int min_size)
     return 0;
  fail:
     qemu_free(new_table);
-    return -EIO;
+    return ret < 0 ? ret : -EIO;
 }