]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-98512: Add more tests for `ValuesView` (#98515)
authorNikita Sobolev <mail@sobolevn.me>
Thu, 3 Nov 2022 02:10:42 +0000 (05:10 +0300)
committerGitHub <noreply@github.com>
Thu, 3 Nov 2022 02:10:42 +0000 (19:10 -0700)
Lib/test/test_collections.py
Lib/test/test_dictviews.py

index 1e398d6c3c7a3f011056048b1ab8698318e87457..35ba5e97528b844be89fca78dd3aa2a62ac90de2 100644 (file)
@@ -1602,6 +1602,7 @@ class TestCollectionABCs(ABCTestCase):
         containers = [
             seq,
             ItemsView({1: nan, 2: obj}),
+            KeysView({1: nan, 2: obj}),
             ValuesView({1: nan, 2: obj})
         ]
         for container in containers:
@@ -1865,6 +1866,8 @@ class TestCollectionABCs(ABCTestCase):
         mymap['red'] = 5
         self.assertIsInstance(mymap.keys(), Set)
         self.assertIsInstance(mymap.keys(), KeysView)
+        self.assertIsInstance(mymap.values(), Collection)
+        self.assertIsInstance(mymap.values(), ValuesView)
         self.assertIsInstance(mymap.items(), Set)
         self.assertIsInstance(mymap.items(), ItemsView)
 
index 7c48d800cd88bdf7f8e909a4886dac4d3055b0d5..924f4a6829e19c3f16cfad7bba70135611bdff23 100644 (file)
@@ -338,6 +338,9 @@ class DictSetTest(unittest.TestCase):
         self.assertIsInstance(d.values(), collections.abc.ValuesView)
         self.assertIsInstance(d.values(), collections.abc.MappingView)
         self.assertIsInstance(d.values(), collections.abc.Sized)
+        self.assertIsInstance(d.values(), collections.abc.Collection)
+        self.assertIsInstance(d.values(), collections.abc.Iterable)
+        self.assertIsInstance(d.values(), collections.abc.Container)
 
         self.assertIsInstance(d.items(), collections.abc.ItemsView)
         self.assertIsInstance(d.items(), collections.abc.MappingView)