]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
perf pmu: Avoid segv for missing name/alias_name in wildcarding
authorIan Rogers <irogers@google.com>
Tue, 27 May 2025 21:50:35 +0000 (14:50 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 28 May 2025 13:12:47 +0000 (10:12 -0300)
The pmu name or alias_name fields may be NULL and should be skipped if
so. This is done in all loops of perf_pmu___name_match except the
final wildcard loop which was an oversight.

Fixes: 63e287131cf0c59b ("perf pmu: Rename name matching for no suffix or wildcard variants")
Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250527215035.187992-1-irogers@google.com
[ Fixup the Fixes: tag to the right commit ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/pmu.c

index bc1178234d3b1bf3b08af2e3089d32fb32c789e7..609828513f6cfb18344849ddd1b227fdb4a2efbf 100644 (file)
@@ -2143,6 +2143,9 @@ static bool perf_pmu___name_match(const struct perf_pmu *pmu, const char *to_mat
        for (size_t i = 0; i < ARRAY_SIZE(names); i++) {
                const char *name = names[i];
 
+               if (!name)
+                       continue;
+
                if (wildcard && perf_pmu__match_wildcard_uncore(name, to_match))
                        return true;
                if (!wildcard && perf_pmu__match_ignoring_suffix_uncore(name, to_match))