]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: ufs: core: Remove redundant host_lock calls around UTRLCLR.
authorAvri Altman <avri.altman@wdc.com>
Thu, 24 Oct 2024 07:50:33 +0000 (10:50 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Oct 2024 19:03:15 +0000 (15:03 -0400)
There is no need to serialize single read/write calls to the host
controller registers. Remove the redundant host_lock calls that protect
access to the request list cLear register: UTRLCLR.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Link: https://lore.kernel.org/r/20241024075033.562562-4-avri.altman@wdc.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c

index f6e84a3bfcf477138a2e557b08210199d6a2401c..9458ecc1c10e3d4fdd5eca4d41f4d0d3cdf4e163 100644 (file)
@@ -3062,7 +3062,6 @@ bool ufshcd_cmd_inflight(struct scsi_cmnd *cmd)
 static int ufshcd_clear_cmd(struct ufs_hba *hba, u32 task_tag)
 {
        u32 mask;
-       unsigned long flags;
        int err;
 
        if (hba->mcq_enabled) {
@@ -3082,9 +3081,7 @@ static int ufshcd_clear_cmd(struct ufs_hba *hba, u32 task_tag)
        mask = 1U << task_tag;
 
        /* clear outstanding transaction before retry */
-       spin_lock_irqsave(hba->host->host_lock, flags);
        ufshcd_utrl_clear(hba, mask);
-       spin_unlock_irqrestore(hba->host->host_lock, flags);
 
        /*
         * wait for h/w to clear corresponding bit in door-bell.