]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: ethernet: natsemi: Use pure PCI devres API
authorPhilipp Stanner <phasta@kernel.org>
Fri, 25 Apr 2025 08:57:37 +0000 (10:57 +0200)
committerJakub Kicinski <kuba@kernel.org>
Mon, 28 Apr 2025 23:19:16 +0000 (16:19 -0700)
The currently used function pci_request_regions() is one of the
problematic "hybrid devres" PCI functions, which are sometimes managed
through devres, and sometimes not (depending on whether
pci_enable_device() or pcim_enable_device() has been called before).

The PCI subsystem wants to remove this behavior and, therefore, needs to
port all users to functions that don't have this problem.

Replace pci_request_regions() with pcim_request_all_regions().

Signed-off-by: Philipp Stanner <phasta@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250425085740.65304-6-phasta@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/natsemi/natsemi.c

index 05606692e631902c299b43725b2b9d51e9ff3af2..dd279788cf9eb65ff9c4f02761e81e82f97933ec 100644 (file)
@@ -846,7 +846,7 @@ static int natsemi_probe1(struct pci_dev *pdev, const struct pci_device_id *ent)
                return -ENOMEM;
        SET_NETDEV_DEV(dev, &pdev->dev);
 
-       i = pci_request_regions(pdev, DRV_NAME);
+       i = pcim_request_all_regions(pdev, DRV_NAME);
        if (i)
                goto err_pci_request_regions;