]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mm: uninline kstrdup()
authorAlexey Dobriyan <adobriyan@gmail.com>
Tue, 28 Feb 2023 15:34:38 +0000 (18:34 +0300)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 8 Apr 2023 20:45:37 +0000 (13:45 -0700)
gcc inlines kstrdup into kstrdup_const() but it can very efficiently tail
call into it instead:

$ ./scripts/bloat-o-meter ../vmlinux-000 ../obj/vmlinux
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-84 (-84)
Function                                     old     new   delta
kstrdup_const                                119      35     -84

Link: https://lkml.kernel.org/r/Y/4fDlbIhTLNLFHz@p183
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/util.c

index b8ed9dbc7fd55b4dea595e64718315e939fd9bb3..dd12b9531ac4cad5f37879c2412719b3724ecb78 100644 (file)
--- a/mm/util.c
+++ b/mm/util.c
@@ -49,6 +49,7 @@ EXPORT_SYMBOL(kfree_const);
  *
  * Return: newly allocated copy of @s or %NULL in case of error
  */
+noinline
 char *kstrdup(const char *s, gfp_t gfp)
 {
        size_t len;